Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start release notes with "Update considerations and deprecations" section #1105

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Start release notes with "Update considerations and deprecations" section #1105

merged 1 commit into from
Mar 25, 2024
+4 −4

Conversation

rickie
Copy link
Member

@rickie rickie commented Mar 23, 2024

Discussed this offline with @Stephan202.

When we have an update consideration or deprecation, it's usually quite important, so we want to have it at the top of the release notes. An example is the release notes from v0.16.0: https://github.com/PicnicSupermarket/error-prone-support/releases/tag/v0.16.0.

@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Mar 23, 2024
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie
Copy link
Member Author

rickie commented Mar 23, 2024 •
edited by Stephan202
Loading

Suggested commit message:

Start release notes with "Update considerations and deprecations" section (#1105)

@rickie rickie added this to the 0.17.0 milestone Mar 23, 2024
@Stephan202
Copy link
Member

^ Proposal to use quotes, as it's not code :)

@Stephan202 Stephan202 changed the title Start release notes with Update considerations and deprecations Start release notes with "Update considerations and deprecations" section Mar 24, 2024
@rickie rickie force-pushed the rossendrijver/releasenotes branch from 282a9c6 to 520e756 Compare March 25, 2024 09:41
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

mohamedsamehsalah
mohamedsamehsalah approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️

@Stephan202 Stephan202 merged commit 9d8a5af into master Mar 25, 2024
15 checks passed
@Stephan202 Stephan202 deleted the rossendrijver/releasenotes branch March 25, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rickie @Stephan202 @mohamedsamehsalah